Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CreateNamedPipeServerStream to named pipes options #56567

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jul 2, 2024

Fixes #53306
Fixes #56568

Named pipes transport allows pipe security to be configured, but it's applied to all of server's named pipe endpoints.

This PR adds CreateNamedPipeServerStream func to options, allowing advanced users to customize creating endpoints. They can choose to specify different PipeSecurity options on a per-endpoint basis.

This feature is modeled after SocketTransportOptions.CreateBoundListenSocket.

@JamesNK JamesNK added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Jul 2, 2024
@JamesNK JamesNK force-pushed the jamesnk/namedpipes-endpoint-security branch from 2053b36 to 5adbdc8 Compare July 4, 2024 00:50
@JamesNK
Copy link
Member Author

JamesNK commented Jul 4, 2024

API is approved. Ready for review.

@JamesNK JamesNK enabled auto-merge (squash) July 9, 2024 00:30
@JamesNK JamesNK merged commit 3105342 into main Jul 9, 2024
26 checks passed
@JamesNK JamesNK deleted the jamesnk/namedpipes-endpoint-security branch July 9, 2024 02:27
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview7 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
2 participants